Skip to content

Optimize TranslateString() #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Optimize TranslateString() #383

merged 1 commit into from
May 22, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented May 21, 2025 •
edited
Loading

  • Call _ = output.AppendLiteral(str); instead of iterating over string's chars for strings without special chars
  • Remove unreferenced TranslateStringChar()
  • Fix misspelling effecient -> efficient

@SergeiPavlov SergeiPavlov merged commit 270fbf5 into master-servicetitan May 22, 2025
5 checks passed
@SergeiPavlov SergeiPavlov deleted the TranslateString branch May 22, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@botinko botinko botinko approved these changes

@snaumenko-st snaumenko-st Awaiting requested review from snaumenko-st

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergeiPavlov @botinko